rmuir commented on pull request #709: URL: https://github.com/apache/lucene/pull/709#issuecomment-1059085772
For the record this DocIdSetBuilder.Buffer has been so damaging to our code, insanely, I'm still here trying to calm down the explosion of horribleness caused by it. I opened https://issues.apache.org/jira/browse/LUCENE-10443 as a second pass to this PR to try to really dig into the situation. Personally I am in favor of switching back to SparseFixedBitSet. Sticking with bitsets help defend against so many bad decisions such as bringing `long` into these apis when its not needed. I actually don't mind if the performance drops a bit to use the `SparseFixedBitSet` instead of this horrible "buffer". We have to take care of complexity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
