iverase commented on a change in pull request #709:
URL: https://github.com/apache/lucene/pull/709#discussion_r813988648
##########
File path: lucene/core/src/java/org/apache/lucene/util/DocIdSetBuilder.java
##########
@@ -266,20 +224,12 @@ private void upgradeToBitSet() {
public DocIdSet build() {
try {
if (bitSet != null) {
- assert counter >= 0;
- final long cost = Math.round(counter / numValuesPerDoc);
- return new BitDocIdSet(bitSet, cost);
+ return new BitDocIdSet(bitSet);
} else {
Buffer concatenated = concat(buffers);
LSBRadixSorter sorter = new LSBRadixSorter();
sorter.sort(PackedInts.bitsRequired(maxDoc - 1), concatenated.array,
concatenated.length);
- final int l;
- if (multivalued) {
- l = dedup(concatenated.array, concatenated.length);
Review comment:
Do we really want to throw away this optimisation? we normally know if
our data is single or multi-valued so it seems wasteful not to exploit it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
