msokolov commented on pull request #446: URL: https://github.com/apache/lucene/pull/446#issuecomment-993640438
> Why do we need to exclude small segments from regular merges? If we selected some small segments as part of a full-flush merge, then they wouldn't be available to also be included in a regular merge, right? I also noticed that in IndexWriter where we call findFullFlushMerges, we only do so for merge triggers `GET_READER` and `COMMIT`, but *not* for trigger `FULL_FLUSH`, which seems quite confusing. I wonder if we could find a better name for `findFullFlushMerges`. Also, given that both `findMerges` and `findFullFlushMerges` are both called from the same switch statement, and for different triggers, *and the trigger is passed in as an argument* -- we could get rid of `findFullFlushMerges`, *always* call `findMerges`, and let the merge policy decide what to do based on the value of `trigger`. @s1monw WDTY? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
