codaitya edited a comment on pull request #446: URL: https://github.com/apache/lucene/pull/446#issuecomment-990921102
I have looked more into the workings of other merge policies (mainly LogMergePolicy) . I found it is difficult to generalize the change in this PR to work with all the policies. I am doing two main changes in this PR 1. easy to configure merge-on-commit merges for small segments 2. ensure no merged segment is accidentally too big a percentage of the total index I think 2 fits naturally with TieredMergePolicy since I calculate this max size and set it for `TieredMergePolicy.setMaxMergedSegmentMB()` . So I am thinking of revising this PR with only change 1(easy to configure merge-on-commit merges ) and make it generic to work with all merge polcies. What do you think Mike ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
