jpountz commented on pull request #446:
URL: https://github.com/apache/lucene/pull/446#issuecomment-993590295


   Why do we need to exclude small segments from regular merges? E.g. if a 
merge-on-flush merges small segments and the resulting segment is small too, we 
don't want to exclude it from regular merges, do we?
   
   Because it creates merges manually, this merge policy cannot take advantage 
of some specifics of the wrapped merge policy like the merge factor. I wonder 
if a better implementation would consist of calling `findMerges` and filter out 
merges that are too large?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to