msokolov commented on pull request #446: URL: https://github.com/apache/lucene/pull/446#issuecomment-991310522
> So I am thinking of revising this PR with only change 1(easy to configure merge-on-commit merges ) and make it generic to work with all merge polcies. What do you think Mike ? As I look at this, it is kind of strange that we call `setMaxMergedSegmentMB` in `findMerges` because if a user set that explicitly, we would then override it based on the max size as percentage of index, which could be surprising. I think this max size as proportion of index is a nice feature, but I'm not sure it really has anything to do with finding small segments to merge on refresh? So +1 to dropping that feature. Maybe @msfroh will remember why it's in here -- is it just for convenience? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
