msokolov commented on a change in pull request #534:
URL: https://github.com/apache/lucene/pull/534#discussion_r768748046
##########
File path: lucene/core/src/java/org/apache/lucene/index/VectorValuesWriter.java
##########
@@ -109,11 +110,15 @@ private void updateBytesUsed() {
public void flush(Sorter.DocMap sortMap, KnnVectorsWriter knnVectorsWriter)
throws IOException {
VectorValues vectorValues =
new BufferedVectorValues(docsWithField, vectors,
fieldInfo.getVectorDimension());
- if (sortMap != null) {
- knnVectorsWriter.writeField(fieldInfo, new
SortingVectorValues(vectorValues, sortMap));
- } else {
- knnVectorsWriter.writeField(fieldInfo, vectorValues);
- }
+ KnnVectorsReader vectorsReader =
+ new EmptyKnnVectorsReader() {
+ @Override
+ public VectorValues getVectorValues(String field) throws IOException
{
+ return sortMap != null ? new SortingVectorValues(vectorValues,
sortMap) : vectorValues;
Review comment:
Oh, good catch! I think with the current usage it probably never matters
since we only call this once and dispose of the reader, but it would be a trap
waiting for some future usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
