jtibshirani commented on a change in pull request #534:
URL: https://github.com/apache/lucene/pull/534#discussion_r768100327
##########
File path: lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java
##########
@@ -40,7 +41,8 @@
protected KnnVectorsWriter() {}
/** Write all values contained in the provided reader */
- public abstract void writeField(FieldInfo fieldInfo, VectorValues values)
throws IOException;
+ public abstract void writeField(FieldInfo fieldInfo, KnnVectorsReader
knnVectorReader)
Review comment:
Small comment, we use both `vectorsReader` and `knnVectorReader` for
this variable. It'd be nice to use one name consistently (with plural
"vectors").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
