mdmarshmallow commented on pull request #509: URL: https://github.com/apache/lucene/pull/509#issuecomment-992806271
Yeah we would double count ancestors if they are in the same document. I'll need to look more into what exactly "rolling up" is and more on how taxonomy-based faceting works. Also as a side note, I tested this change with high cardinality facets (~50M) and the tree structure took too much heap-space, so I'm wondering if it might be better to then just do what taxonomy does and store every ancestor ordinal and then roll up, though I'll need to test high cardinality faceting with taxonomy just to make sure this issue only occurs in these SSDV facets. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
