mdmarshmallow commented on a change in pull request #509:
URL: https://github.com/apache/lucene/pull/509#discussion_r766907398
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesReaderState.java
##########
@@ -37,19 +38,102 @@
public abstract class SortedSetDocValuesReaderState implements Accountable {
/**
- * Holds start/end range of ords, which maps to one dimension (someday we
may generalize it to map
- * to hierarchies within one dimension).
+ * Class to store ranges of facet label as well as references to children of
that label, key'd by
+ * label string
*/
- public static final class OrdRange {
+ public static final class HierarchicalOrdRange {
/** Start of range, inclusive: */
- public final int start;
- /** End of range, inclusive: */
- public final int end;
-
- /** Start and end are inclusive. */
- public OrdRange(int start, int end) {
- this.start = start;
- this.end = end;
+ private int start = -1;
+ /** End of range, exclusive: */
Review comment:
This should say inclusive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
