uschindler commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r766043869



##########
File path: lucene/licenses/asm-analysis-7.2.jar.sha1
##########
@@ -0,0 +1 @@
+b6e6abe057f23630113f4167c34bda7086691258

Review comment:
       > ASM also has a module-info.class (autogenerated from their dependency 
graph by Remi Forax, not available in source code => see mocobeta's comment).
   
   Actually this code by Remi is cool. We may use a similar approach to 
generate the module-info.class from our Gradle Dependencies and the 
META-INF/services file without actually compiling a module-info.java




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to