uschindler commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r765921053
##########
File path: lucene/licenses/asm-analysis-7.2.jar.sha1
##########
@@ -0,0 +1 @@
+b6e6abe057f23630113f4167c34bda7086691258
Review comment:
@ChrisHegarty: Can you tell the module system in the module-info that
you don't want a transitive requires to apply?
Background: we only need one class from asm-commons, but a require on
asm-commons wants 2 other dependencies which are not used at all because it is
used from another code path only. In Maven/Gradle you can just exclude a
dependency, but the module system complains. So can you say "i require module
xy, but dont make it require others".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
