uschindler commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r766022562
##########
File path: lucene/licenses/asm-analysis-7.2.jar.sha1
##########
@@ -0,0 +1 @@
+b6e6abe057f23630113f4167c34bda7086691258
Review comment:
> > But nevertheless, this seem to be a bug in asm-commons that it
relies on the analysis and tree modules.
>
> FWIW, its module descriptor is automatically generated bypassing
module-info.java. Seems there are no careful human judgements. [dweiss#8
(comment)](https://github.com/dweiss/lucene/pull/8#discussion_r762506185)
The problem is: The requires is correct, if you use all of the JAR file. We
just use one class.
We have 2 options:
- ask ASM to split asm-commons into 2 modules
- fork the GeneratorAdapter (it is just some helper code on top of low-level
ASM so it is easier to create byte code).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
