[ 
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423773#comment-17423773
 ] 

Dawid Weiss commented on LUCENE-10143:
--------------------------------------

How would you know when it's flushed though? RateLimitedIndexOutput accepts a 
generic IndexOutput - nothing is known about its implementation.

> public RateLimitedIndexOutput(final RateLimiter rateLimiter, final 
> IndexOutput delegate)

We could add an intermediate buffer inside (and then check the rate on flush). 
Hard to tell whether this would make much of a difference without trying out 
(and even then, results will vary greatly depending on I/O performance).

> RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong
> --------------------------------------------------------------------
>
>                 Key: LUCENE-10143
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10143
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Priority: Minor
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Otherwise merges are not taking advantage of LUCENE-10125.
> cc [~uschindler]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to