[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423574#comment-17423574
]
Robert Muir commented on LUCENE-10143:
--------------------------------------
I made DataInput.readInt/readShort/readLong and
DataOutput.writeInt/writeShort/writeLong all abstract. compiler output then
tells the rest of the story:
{noformat}
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataInput.java:37:
error: ByteBuffersDataInput is not abstract and does not override abstract
method readLong() in DataInput
public final class ByteBuffersDataInput extends DataInput
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/util/PagedBytes.java:302:
error: PagedBytes.PagedBytesDataInput is not abstract and does not override
abstract method readLong() in DataInput
public final class PagedBytesDataInput extends DataInput {
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/util/PagedBytes.java:379:
error: PagedBytes.PagedBytesDataOutput is not abstract and does not override
abstract method writeLong(long) in DataOutput
public final class PagedBytesDataOutput extends DataOutput {
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/index/ByteSliceReader.java:30:
error: ByteSliceReader is not abstract and does not override abstract method
readLong() in DataInput
final class ByteSliceReader extends DataInput {
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/util/fst/BytesStore.java:30:
error: BytesStore is not abstract and does not override abstract method
writeLong(long) in DataOutput
class BytesStore extends DataOutput implements Accountable {
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/util/fst/BytesStore.java:381:
error: <anonymous org.apache.lucene.util.fst.BytesStore$1> is not abstract and
does not override abstract method readLong() in DataInput
return new FST.BytesReader() {
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/util/fst/BytesStore.java:451:
error: <anonymous org.apache.lucene.util.fst.BytesStore$2> is not abstract and
does not override abstract method readLong() in DataInput
return new FST.BytesReader() {
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/util/fst/ReverseRandomAccessReader.java:23:
error: ReverseRandomAccessReader is not abstract and does not override
abstract method readLong() in DataInput
final class ReverseRandomAccessReader extends FST.BytesReader {
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/util/fst/ForwardBytesReader.java:23:
error: ForwardBytesReader is not abstract and does not override abstract
method readLong() in DataInput
final class ForwardBytesReader extends FST.BytesReader {
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/util/fst/ReverseBytesReader.java:20:
error: ReverseBytesReader is not abstract and does not override abstract
method readLong() in DataInput
final class ReverseBytesReader extends FST.BytesReader {
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java:311:
error: abstract method writeShort(short) in DataOutput cannot be accessed
directly
super.writeShort(v);
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java:324:
error: abstract method writeInt(int) in DataOutput cannot be accessed directly
super.writeInt(v);
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java:337:
error: abstract method writeLong(long) in DataOutput cannot be accessed
directly
super.writeLong(v);
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/store/ByteBufferIndexInput.java:220:
error: abstract method readShort() in DataInput cannot be accessed directly
return super.readShort();
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/store/ByteBufferIndexInput.java:235:
error: abstract method readInt() in DataInput cannot be accessed directly
return super.readInt();
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/store/ByteBufferIndexInput.java:250:
error: abstract method readLong() in DataInput cannot be accessed directly
return super.readLong();
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/store/BufferedIndexInput.java:140:
error: abstract method readShort() in DataInput cannot be accessed directly
return super.readShort();
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/store/BufferedIndexInput.java:149:
error: abstract method readInt() in DataInput cannot be accessed directly
return super.readInt();
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/store/BufferedIndexInput.java:158:
error: abstract method readLong() in DataInput cannot be accessed directly
return super.readLong();
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/store/OutputStreamDataOutput.java:22:
error: OutputStreamDataOutput is not abstract and does not override abstract
method writeLong(long) in DataOutput
public class OutputStreamDataOutput extends DataOutput implements Closeable {
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/store/InputStreamDataInput.java:22:
error: InputStreamDataInput is not abstract and does not override abstract
method readLong() in DataInput
public class InputStreamDataInput extends DataInput implements Closeable {
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/store/BufferedChecksumIndexInput.java:26:
error: BufferedChecksumIndexInput is not abstract and does not override
abstract method readLong() in DataInput
public class BufferedChecksumIndexInput extends ChecksumIndexInput {
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/store/RateLimitedIndexOutput.java:26:
error: RateLimitedIndexOutput is not abstract and does not override abstract
method writeLong(long) in DataOutput
public final class RateLimitedIndexOutput extends IndexOutput {
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/index/ByteSliceWriter.java:28:
error: ByteSliceWriter is not abstract and does not override abstract method
writeLong(long) in DataOutput
final class ByteSliceWriter extends DataOutput {
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/codecs/MultiLevelSkipListReader.java:284:
error: SkipBuffer is not abstract and does not override abstract method
readLong() in DataInput
private static final class SkipBuffer extends IndexInput {
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java:544:
error: <anonymous
org.apache.lucene.codecs.lucene90.compressing.Lucene90CompressingStoredFieldsReader$BlockState$1>
is not abstract and does not override abstract method readLong() in DataInput
new DataInput() {
^
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90NormsProducer.java:289:
error: <anonymous org.apache.lucene.codecs.lucene90.Lucene90NormsProducer$1>
is not abstract and does not override abstract method readInt() in DataInput
return new IndexInput("docs") {
^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
27 errors
{noformat}
> RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong
> --------------------------------------------------------------------
>
> Key: LUCENE-10143
> URL: https://issues.apache.org/jira/browse/LUCENE-10143
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Priority: Minor
>
> Otherwise merges are not taking advantage of LUCENE-10125.
> cc [~uschindler]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
