jtibshirani commented on a change in pull request #267: URL: https://github.com/apache/lucene/pull/267#discussion_r702206125
########## File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java ########## @@ -66,13 +69,15 @@ * @param beamWidth the size of the beam search to use when finding nearest neighbors. * @param seed the seed for a random number generator used during graph construction. Provide this * to ensure repeatable construction. + * @param ml normalization factor for level generation */ public HnswGraphBuilder( RandomAccessVectorValuesProducer vectors, VectorSimilarityFunction similarityFunction, int maxConn, int beamWidth, - long seed) { + long seed, + double ml) { Review comment: Super small comment, this could go above `seed` to be grouped with other parameters `maxConn` and `beamWidth`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org