jtibshirani commented on a change in pull request #267:
URL: https://github.com/apache/lucene/pull/267#discussion_r702205240
##########
File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java
##########
@@ -188,29 +244,95 @@ public int size() {
}
// TODO: optimize RAM usage so not to store references for all nodes for
levels > 0
+ // TODO: add extra levels if level >= numLevels
Review comment:
Do we still need this TODO?
##########
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java
##########
@@ -480,8 +480,12 @@ private void readValue(int targetOrd) throws IOException {
this.dataIn = dataIn;
}
+ // TODO : implement hierarchy
Review comment:
Do we still need this TODO?
##########
File path:
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java
##########
@@ -66,13 +69,15 @@
* @param beamWidth the size of the beam search to use when finding nearest
neighbors.
* @param seed the seed for a random number generator used during graph
construction. Provide this
* to ensure repeatable construction.
+ * @param ml normalization factor for level generation
*/
public HnswGraphBuilder(
RandomAccessVectorValuesProducer vectors,
VectorSimilarityFunction similarityFunction,
int maxConn,
int beamWidth,
- long seed) {
+ long seed,
+ double ml) {
Review comment:
Super small comment, this could go above seed to be grouped with other
parameters `maxConn` and `beamWidth`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
