mayya-sharipova edited a comment on pull request #267: URL: https://github.com/apache/lucene/pull/267#issuecomment-911636658
@jtibshirani > Maybe we could at least prevent ml from being 0 so we could remove the flat graph code path? This would be a nice simplification and I can't think of a use case for keeping a flat graph implementation as part of the HNSW codec. I agree, this indeed will be a good simplification. Just wanted to confirm that we are ok with not having a flat graph implementation? I've checked [ann-benchmarks](https://github.com/erikbern/ann-benchmarks), and on their datasets HNSW always outperforms SW-graph, so I think it is ok to have HNSW only. @jtibshirani Can we remove the flat graph part when we implement on the disk storage? Currently for tests that use indices, we use flat graph, and we remove this part, I think these tests will not work. --- > This feels like an independent fix, maybe we could pull it into its own PR against main so it doesn't just sit on the feature branch? Created a PR https://github.com/apache/lucene/pull/277 against master branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
