dsmiley commented on a change in pull request #205:
URL: https://github.com/apache/lucene/pull/205#discussion_r665342391
##########
File path: lucene/core/src/java/org/apache/lucene/index/SegmentCoreReaders.java
##########
@@ -57,7 +57,7 @@
final NormsProducer normsProducer;
final StoredFieldsReader fieldsReaderOrig;
- final TermVectorsReader termVectorsReaderOrig;
+ final TermVectorsReaderBase termVectorsReaderOrig;
Review comment:
Sigh; I'm not sure what to do then. The non-harmoneous aspect is a code
smell but if it's very limited (not widespread) then it's not a big deal I
guess. Otherwise it's a stronger indicator there is misalignment. I'm not
really sure why there needs to be _both_ TermVectorsReader &
TermVectorsReaderBase any way but surely you & Adrien do so I leave that to
your judgement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
