zacharymorn commented on a change in pull request #205:
URL: https://github.com/apache/lucene/pull/205#discussion_r665060449
##########
File path: lucene/core/src/java/org/apache/lucene/index/SegmentCoreReaders.java
##########
@@ -57,7 +57,7 @@
final NormsProducer normsProducer;
final StoredFieldsReader fieldsReaderOrig;
- final TermVectorsReader termVectorsReaderOrig;
+ final TermVectorsReaderBase termVectorsReaderOrig;
Review comment:
Yeah this indeed looks inconsistent.
I think the main thing here is, the overall understanding I got from
https://github.com/apache/lucene/pull/180#discussion_r650720327 &
https://github.com/apache/lucene/pull/180#discussion_r653357562 (this comment
specifically asked not to move up `Closeable` from the original
`TermVectorsReader`) is that, the new `TermVectors / TermVectorsReader`
abstraction is supposed to be an index API, while the original
`TermVectorsReader` / now `TermVectorsReaderBase` is a codec API, which has
`clone/getMergeInstance/checkIntegrity` methods, and also implements
`Closeable` (and all other `*Reader/Producer` codec classes also implement
`Closeable` as well). If we were to move `Closeable` from
`TermVectorsReaderBase` to the new `TermVectorsReader`, wouldn't that break the
separation there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
