zacharymorn commented on pull request #205: URL: https://github.com/apache/lucene/pull/205#issuecomment-874499672
> I'm also okay with introducing the new/simpler TermVectorsReader abstraction if it would reduce this PR diff a lot. Up to you. Thanks @dsmiley for the review and approval! I've thought about having the new `TermVectorsReader` here as well, but I'm leaning more towards introducing it in the other PR after some digging, as I see so far the majority of `TermVectorsReaderBase` usage here involves using the existing codec APIs `checkIntegrity/clone/getMergeInstance`, so the newer `TermVectorsReader` class (that may not have any method yet) may not be usable directly. In addition, introducing it here may also lead to some git merge conflicts with the other PR later as well I feel, as `TermVectors` was already created there as the super class of `TermVectorsReader`. So I think saving it for the other PR may be an easier approach overall? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
