gsmiller commented on a change in pull request #142:
URL: https://github.com/apache/lucene/pull/142#discussion_r643949418
##########
File path: lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java
##########
@@ -233,11 +251,32 @@ public ScoreMode scoreMode() {
}
searcher.search(dsq, hitCollector);
+ FacetsCollector drillDownCollector;
+ if (drillDownCollectorManager != null) {
+ drillDownCollector =
drillDownCollectorManager.reduce(dsq.managedDrillDownCollectors);
+ } else {
+ drillDownCollector = null;
+ }
+
+ FacetsCollector[] drillSidewaysCollectors = new FacetsCollector[numDims];
+ int numSlices = dsq.managedDrillSidewaysCollectors.size();
+
+ for (int dim = 0; dim < numDims; dim++) {
+ List<FacetsCollector> facetsCollectorsForDim = new
ArrayList<>(numSlices);
+
+ for (int slice = 0; slice < numSlices; slice++) {
+
facetsCollectorsForDim.add(dsq.managedDrillSidewaysCollectors.get(slice)[dim]);
+ }
+
+ drillSidewaysCollectors[dim] =
+
drillSidewaysFacetsCollectorManagers[dim].reduce(facetsCollectorsForDim);
+ }
+
return new DrillSidewaysResult(
buildFacetsResult(
drillDownCollector,
drillSidewaysCollectors,
- drillDownDims.keySet().toArray(new String[drillDownDims.size()])),
+ drillDownDims.keySet().toArray(new String[0])),
Review comment:
I agree; it's very strange!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
