jpountz edited a comment on pull request #91: URL: https://github.com/apache/lucene/pull/91#issuecomment-839518593
Agreed, this change helped me notice that we are probably lacking coverage for index sorting. Since this is a pre-existing issue, let's work on it in a separate pull request. In my opinion, the two bits that are important to test with your PR are `MutablePointsReaderUtils` in the case when doc IDs are incremental, which looks covered already, and `StableMSBRadixSorter`, let's add a new test for this one similar to `TestMSBRadixSorter` and with additional checks regarding stability? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
