neoremind commented on pull request #91: URL: https://github.com/apache/lucene/pull/91#issuecomment-840373136
> This looks good to me. Can we better check that the sort is actually stable in the tests? E.g. maybe we could verify that the arrays are not only equal after sorting with Arrays#sort and StableMSBRadixSorter but also that they have the very same instance at every index? Add a new assertion `assertSame(points[i].packedValue, reader.points[i].packedValue);`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
