neoremind commented on a change in pull request #91:
URL: https://github.com/apache/lucene/pull/91#discussion_r630267185
##########
File path: lucene/core/src/java/org/apache/lucene/codecs/MutablePointValues.java
##########
@@ -41,4 +41,10 @@ protected MutablePointValues() {}
/** Swap the i-th and j-th values. */
public abstract void swap(int i, int j);
+
+ /** Assign the from-th value to to-th position in another array which used
temporarily. */
+ public abstract void assign(int from, int to);
+
+ /** Finalize assign operation, to switch array. */
+ public abstract void finalizeAssign(int from, int to);
Review comment:
@jpountz After some research, I find it difficult to implement, the
reason is that reorder works on original array, if we make it work for temp
array, there are many code need to be refactored or updated (ie. `byteAt` and
`getValue` remains unchanged, and introduce `byteAtForTemp` works on temp
array), which might be redundant and even harder to maintain in future.
So I would suggest keeping the current semantic of `copy` and `reorder` for
`StableMSBRadixSorter `, the comments are pretty clear indicating how these
methods should be implemented and works. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
