jtibshirani commented on a change in pull request #2444:
URL: https://github.com/apache/lucene-solr/pull/2444#discussion_r589618706



##########
File path: 
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene50/compressing/Lucene50CompressingStoredFieldsReader.java
##########
@@ -654,15 +669,7 @@ public void readBytes(byte[] b, int offset, int len) 
throws IOException {
 
               @Override
               public void skipBytes(long numBytes) throws IOException {
-                if (numBytes < 0) {
-                  throw new IllegalArgumentException("numBytes must be >= 0, 
got " + numBytes);
-                }
-                while (numBytes > bytes.length) {
-                  numBytes -= bytes.length;
-                  fillBuffer();
-                }
-                bytes.offset += numBytes;
-                bytes.length -= numBytes;
+                skipBytesSlowly(numBytes);

Review comment:
       Thanks for clarifying.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to