iverase commented on a change in pull request #2444:
URL: https://github.com/apache/lucene-solr/pull/2444#discussion_r589249744



##########
File path: 
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene87/Lucene87Codec.java
##########
@@ -101,14 +102,22 @@ public DocValuesFormat getDocValuesFormatForField(String 
field) {
 
   /** Instantiates a new codec. */
   public Lucene87Codec() {
+    this(Mode.BEST_COMPRESSION);

Review comment:
       We actually need the default constructor in codecs or you get errors 
like:
   
   ```
   org.apache.lucene.codecs.Codec: 
org.apache.lucene.backward_codecs.lucene87.Lucene87Codec Unable to get public 
no-arg constructor
   java.util.ServiceConfigurationError: org.apache.lucene.codecs.Codec: 
org.apache.lucene.backward_codecs.lucene87.Lucene87Codec Unable to get public 
no-arg constructor
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to