iverase commented on a change in pull request #2444: URL: https://github.com/apache/lucene-solr/pull/2444#discussion_r589262884
########## File path: lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene50/compressing/Lucene50CompressingStoredFieldsFormat.java ########## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.backward_codecs.lucene50.compressing; + +import java.io.IOException; +import org.apache.lucene.codecs.CodecUtil; +import org.apache.lucene.codecs.StoredFieldsFormat; +import org.apache.lucene.codecs.StoredFieldsReader; +import org.apache.lucene.codecs.StoredFieldsWriter; +import org.apache.lucene.codecs.compressing.CompressionMode; +import org.apache.lucene.index.FieldInfos; +import org.apache.lucene.index.MergePolicy; +import org.apache.lucene.index.SegmentInfo; +import org.apache.lucene.store.Directory; +import org.apache.lucene.store.IOContext; +import org.apache.lucene.util.packed.DirectMonotonicWriter; + +/** + * A {@link StoredFieldsFormat} that compresses documents in chunks in order to improve the + * compression ratio. + * + * <p>For a chunk size of <var>chunkSize</var> bytes, this {@link StoredFieldsFormat} does not + * support documents larger than (<code>2<sup>31</sup> - chunkSize</code>) bytes. + * + * <p>For optimal performance, you should use a {@link MergePolicy} that returns segments that have + * the biggest byte size first. + * + * @lucene.experimental + */ +public class Lucene50CompressingStoredFieldsFormat extends StoredFieldsFormat { + + /** format name */ + protected final String formatName; Review comment: Not sure as there are some values which are set using special logic. It seems important to keep those. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
