dsmiley commented on a change in pull request #2343:
URL: https://github.com/apache/lucene-solr/pull/2343#discussion_r582528724
##########
File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java
##########
@@ -56,11 +58,24 @@
private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
public static ConfigSetService createConfigSetService(NodeConfig nodeConfig,
SolrResourceLoader loader, ZkController zkController) {
- if (zkController == null) {
+
+ String configSetServiceClass = nodeConfig.getConfigSetServiceClass();
+
+ if(configSetServiceClass != null){
+ try {
+ Class<? extends ConfigSetService> clazz =
loader.findClass(configSetServiceClass, ConfigSetService.class);
+ Constructor<? extends ConfigSetService> constructor
Review comment:
No. I'm referring to the constructor signature of ConfigSetService.
Replace the Boolean (for schema caching) with NodeConfig. If the
ConfigSetService cares to honor that option (or others), it's up to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
