dsmiley commented on a change in pull request #2343:
URL: https://github.com/apache/lucene-solr/pull/2343#discussion_r584222684
##########
File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java
##########
@@ -65,8 +65,8 @@ public static ConfigSetService
createConfigSetService(NodeConfig nodeConfig, Sol
try {
Class<? extends ConfigSetService> clazz =
loader.findClass(configSetServiceClass, ConfigSetService.class);
Constructor<? extends ConfigSetService> constructor
- = clazz.getConstructor(SolrResourceLoader.class, Boolean.TYPE,
ZkController.class);
- return constructor.newInstance(loader, nodeConfig.hasSchemaCache(),
zkController);
+ = clazz.getConstructor(SolrResourceLoader.class,
NodeConfig.class, ZkController.class);
Review comment:
Looks like we can remove SolrResourceLoader as well, which is on
NodeConfig.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
