baisui1981 commented on a change in pull request #2343:
URL: https://github.com/apache/lucene-solr/pull/2343#discussion_r582437332
##########
File path: solr/core/src/java/org/apache/solr/core/NodeConfig.java
##########
@@ -89,6 +89,8 @@
private final boolean fromZookeeper;
private final String defaultZkHost;
+ private final String configSetServiceClass;
Review comment:
as i see ,there is no ready-made class to store the property
'configSetServiceClass'. it seem that make a new class to store
'configSetServiceClass' and responsible for creating custome ConfigSetService
instance. is that ok?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
