dsmiley commented on a change in pull request #2306:
URL: https://github.com/apache/lucene-solr/pull/2306#discussion_r574273233
##########
File path:
solr/contrib/scripting/src/test/org/apache/solr/scripting/xslt/XSLTUpdateRequestHandlerTest.java
##########
@@ -39,11 +38,17 @@
import org.junit.BeforeClass;
import org.junit.Test;
-public class XsltUpdateRequestHandlerTest extends SolrTestCaseJ4 {
-
+/**
+ * <p>
+ * This tests the XSLTUpdateRequestHandler ability to work with XSLT
stylesheet and xml content.
+ * </p>
+*/
+public class XSLTUpdateRequestHandlerTest extends SolrTestCaseJ4 {
Review comment:
BTW, I the most common naming convention is for acronyms to use camel
case instead of all-caps. This has been a long trend over many years. I know
why you changed it here -- to match the class it's testing, and so it's a net
improvement over what existed. But arguably it's the class it's testing that
should be renamed; not this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
