epugh commented on pull request #2306: URL: https://github.com/apache/lucene-solr/pull/2306#issuecomment-775285291
I think there is a bit of back and forth.. I added a boolean to `XMLLoader` constructor to decide if the tr parameter was acceptible. I was going to have it throw an exception from the `UpdateRequestHandler` if a `tr` was passed in via solr params, but allow it if it was from the `XSLTUpdateRequestHandler`... I'm open to any approach. I wonder if the reason to keep the `TransformerProvider.java` in core is for people who write their own Solr plugins that use it, and not have to require the scripting module? I'm going to push up a set of changes where all the paths work and tests pass momentarily. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
