dsmiley commented on pull request #2306:
URL: https://github.com/apache/lucene-solr/pull/2306#issuecomment-778632312


   > Sorry, my father died on Thursday.
   
   Wow; so sorry to hear!  I fear the same for my own Dad; I can't take his 
existence for granted so I'll be visiting him tomorrow.
   
   > I will review later as some "long term specialist" 😉 on XML processing.
   
   You're not the only one; I'm a long-time XML fan :-)  It seems the new kids 
know little about such things :-/  "What is this weird syntax... " as he/she 
goes off to then write a dozen lines that an XPath does in one.
   
   I kept the all-caps XSLT despite my preferences because All of the XML 
related APIs we use are using all-caps for XML and thus it looked off to see it 
differently.  But then... the user doesn't know that and sees XML in the config 
file so...   Hmm.
   
   Maybe the XSLT response writer should demand "tr" and thus be more 
consistent with the XSLT response writer?  After all, you're choosing to send 
the response there so why would you send it there if it wasn't? I guess it 
gives you choice and the ability to be more similar to what we have today.  
Shrug.
   
   We need some docs to show how to reference the XSLT update handler, or at 
the very least an upgrade note about this.
   
   I hate the crappy caching; it's inferior to a SolrCache but alas... I hold 
myself back from feature-creep.  This code was written forever-ago so I can 
appreciate it has excuses.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to