NazerkeBS commented on a change in pull request #2230:
URL: https://github.com/apache/lucene-solr/pull/2230#discussion_r568061888
##########
File path: solr/webapp/web/js/angular/services.js
##########
@@ -58,10 +58,10 @@ solrAdminServices.factory('System',
}])
.factory('Logging',
['$resource', function($resource) {
- return $resource('admin/info/logging', {'wt':'json', 'nodes': 'all',
'_':Date.now()}, {
+ return $resource('admin/info/logging', {'wt':'json', '_':Date.now()}, {
"events": {params: {since:'0'}},
"levels": {},
- "setLevel": {}
+ "setLevel": {'nodes': 'all'}
Review comment:
I debugged it on Admin UI and it works without `params`. But I updated
my PR to use `params` as other handlers also use `params` in this file .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
