dsmiley commented on a change in pull request #2230:
URL: https://github.com/apache/lucene-solr/pull/2230#discussion_r565608099
##########
File path: solr/webapp/web/js/angular/services.js
##########
@@ -58,7 +58,7 @@ solrAdminServices.factory('System',
}])
.factory('Logging',
['$resource', function($resource) {
- return $resource('admin/info/logging', {'wt':'json', '_':Date.now()}, {
+ return $resource('admin/info/logging', {'wt':'json', 'nodes': 'all',
'_':Date.now()}, {
Review comment:
Okay; I see you improved that from an earlier commit.
@janhoy maybe you could take a look at this please. Should nodes=all should
only be added when setLevel is submitted, not for all logging handler
interactions. Do you think this is done correctly here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
