murblanc commented on a change in pull request #2199:
URL: https://github.com/apache/lucene-solr/pull/2199#discussion_r559763883
##########
File path:
solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementConfig.java
##########
@@ -43,14 +46,30 @@
@JsonProperty
public long prioritizedFreeDiskGB;
+ /**
+ * This property defines an additional constraint that primary collections
(keys) should be
+ * located on the same nodes as the secondary collections (values). The
plugin will assume
+ * that the secondary collection replicas are already in place and ignore
candidate nodes where
+ * they are not already present.
+ */
+ @JsonProperty
+ public Map<String, String> withCollections;
+
// no-arg public constructor required for deserialization
public AffinityPlacementConfig() {
minimalFreeDiskGB = 20L;
Review comment:
I prefer the no arg constructor here to call the appropriate
constructor. That way logic is not replicated (might not be applicable here
unless somebody replaces `withCollections = Map.of();` with `withCollections =
null;` in a future commit), it looks cleaner and by tracing calls to the most
complete constructor all callers are inventoried...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
