zacharymorn opened a new pull request #2205: URL: https://github.com/apache/lucene-solr/pull/2205
# Description Deprecate MinShouldMatchSumScorer with WANDScorer since the two are very similar at this point. This is a follow-up PR to https://github.com/apache/lucene-solr/pull/2141 . # Solution As `WANDScorer` can already handle the cases where `scoreMode.needsScore() == true`, and `MinShouldMatchSumScorer` can handle the cases where `scoreMode.needsScore() == false` , this PR deprecates `MinShouldMatchSumScorer` with `WANDScorer` primarily by skipping block-max scoring update related logic when `scoreMode.needsScore() == false`. # Tests The existing tests as well as 3 newly added tests are passing (currently the nocommit comment fails validation check). # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `master` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
