murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r545162052
########## File path: solr/core/src/java/org/apache/solr/cluster/placement/ReplicaMetric.java ########## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.cluster.placement; + +import java.util.Objects; +import java.util.function.Function; + +/** + * Replica metric wrapper that defines a short symbolic name of the metric, the corresponding + * internal metric name (as reported in <code>solr.core.[collection].[replica]</code> registry) + * and the desired format/unit conversion. + */ +public class ReplicaMetric<T> { + + private static final double GB = 1024 * 1024 * 1024; + @SuppressWarnings("unchecked") + private final Function<Object, T> NO_CONVERTER = v -> { Review comment: I'd rather have this named `IDENTITY_CONVERTER` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
