murblanc commented on a change in pull request #2133:
URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r545143577
##########
File path:
solr/core/src/java/org/apache/solr/cluster/placement/AttributeFetcher.java
##########
@@ -78,13 +85,15 @@
AttributeFetcher fetchFrom(Set<Node> nodes);
/**
- * Requests a (non node) metric of a given scope and name. To get the value
use {@link AttributeValues#getMetric(String, String)}
+ * Requests any metric from any metric registry on each node, using a
fully-qualified metric key,
+ * for example <code>solr.jvm:system.properties:user.name</code>.
+ * To get the value use {@link AttributeValues#getNodeMetric(Node, String)}
*/
- AttributeFetcher requestMetric(String scope, String metricName);
+ AttributeFetcher requestNodeMetric(String metricKey);
Review comment:
Move this method closer to the other `requestNodeMetric` above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
