zacharymorn commented on pull request #2068: URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-724434703
> Zach I've cleaned up the native build a bit - moved it under lucene/misc, added Windows build (it does build the native library for me). I didn't check whether it works on a Mac but I suspect it should. > > I also left the native project included by default in settings (removed the "optional" flag). Gradle's cpp plugin ignores the project on platforms not explicitly mentioned in the targetMachines - I am curious whether we'll blow up something or if it's just going to work. > > While I don't particularly like having native code in Lucene, I think it's better than it used to be (mixed cpp code with java code, etc.). > > I allowed myself to commit directly to your fork, hope you don't mind (please test it out!). Thanks Dawid for the changes! I tested it out in my mac and it built fine as well. I originally separated out into an independent native module thinking that it could host future native code as well, but I guess that's probably just pre-mature optimization as it hasn't been the case for the last few years. > I am curious whether we’ll blow up something or if it’s just going to work. Just curious, are there any cross-platform tests as well in the pipeline that can confirm this? How do we verify this other than running local builds? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
