zacharymorn commented on pull request #2068: URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-723700269
> I added some general comments. The code, as it is now, doesn't compile for me on Windows (fails to find includes as they're under win32). Even if I add the includes, it fails on compiling the source code. I think the whole native compilation thing should be ignored on Windows as it's not going to work now. Thanks for the comments! I think the reason of failure even with /win32 inclusion is that the native module currently only includes `NativePoxisUtil.cpp`, which seems to be for unix only. The windows equivalent`WindowsDirectory.cpp` still sits in `misc` module and hasn't been moved over yet. From where we are now with the native module, in order to support Windows, we probably just need to add some logic in `build.gradle` to pick the right source and include folders, as well as passing in custom compiler flags. But yes I also feel that this can be tackled in a later stage after the changes for unix are in good shape. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
