zacharymorn commented on a change in pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#discussion_r521068544
##########
File path: lucene/misc/src/java/org/apache/lucene/store/NativeUnixDirectory.java
##########
@@ -47,10 +47,10 @@
*
* <p>To use this you must compile
* NativePosixUtil.cpp (exposes Linux-specific APIs through
- * JNI) for your platform, by running <code>ant
- * build-native-unix</code>, and then putting the resulting
- * <code>libNativePosixUtil.so</code> (from
- * <code>lucene/build/native</code>) onto your dynamic
+ * JNI) for your platform, by running <code>
+ * ./gradlew build -Pbuild.native=true</code>, and then putting the resulting
Review comment:
Updated.
##########
File path: lucene/packaging/build.gradle
##########
@@ -32,7 +32,9 @@ def includeInBinaries =
project(":lucene").subprojects.findAll {subproject ->
":lucene:packaging",
":lucene:documentation",
// Exclude parent container project of analysis modules (no artifacts).
- ":lucene:analysis"
+ ":lucene:analysis",
+ // Exclude native module, which requires manual copying and enabling
+ ":lucene:native"
Review comment:
It did fail, I've updated the reference here and confirmed it's able to
build from directory root.
##########
File path: lucene/misc/native/build.gradle
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/*
+ * This gets separated out from misc module into a native module due to
incompatibility between cpp-library and java-library plugins.
+ * For details, please see
https://github.com/gradle/gradle-native/issues/352#issuecomment-461724948
+ */
+import org.apache.tools.ant.taskdefs.condition.Os
+
+description = 'Module for native code'
+
+apply plugin: 'cpp-library'
+
+library {
+ baseName = 'NativePosixUtil'
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
