[
https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226930#comment-17226930
]
Erick Erickson commented on SOLR-8330:
--------------------------------------
Without thinking about it too much, I'm in favor of as detailed, relevant
information as possible. Having the abstract class name instead of the concrete
class seems wrong.
I'd be in favor of there being no loggers in abstract classes at all, although
I could be talked out of that.
The one in RequestHandlerBase is particularly strange. The only usage is in
handleRequest, where it's passed as a parameter:
{code}
SolrException.log(log, e);
{code}
So it's not even like a subclass is using it except if the subclass calls
super.handleRequest().....
> Restrict logger visibility throughout the codebase to private so that only
> the file that declares it can use it
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-8330
> URL: https://issues.apache.org/jira/browse/SOLR-8330
> Project: Solr
> Issue Type: Sub-task
> Affects Versions: 6.0
> Reporter: Jason Gerlowski
> Assignee: Anshum Gupta
> Priority: Major
> Labels: logging
> Fix For: 5.4, 6.0
>
> Attachments: SOLR-8330-combined.patch, SOLR-8330-detector.patch,
> SOLR-8330-detector.patch, SOLR-8330.patch, SOLR-8330.patch, SOLR-8330.patch,
> SOLR-8330.patch, SOLR-8330.patch, SOLR-8330.patch, SOLR-8330.patch
>
>
> As Mike Drob pointed out in Solr-8324, many loggers in Solr are
> unintentionally shared between classes. Many instances of this are caused by
> overzealous copy-paste. This can make debugging tougher, as messages appear
> to come from an incorrect location.
> As discussed in the comments on SOLR-8324, there also might be legitimate
> reasons for sharing loggers between classes. Where any ambiguity exists,
> these instances shouldn't be touched.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
