[
https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233112#comment-17233112
]
David Smiley commented on SOLR-8330:
------------------------------------
FYI [~hossman]; you may have an opinion as well since I see you filed SOLR-4833
which refers to http://slf4j.org/faq.html#declared_static I looked at that; the
analysis didn't consider the class hierarchy / subclassing factor.
I filed SOLR-15005 to change RequestHandlerBase's logger. While just that one
little change is probably not controversial, please weight in on wether or not
the subclasses should remove loggers they have in lieu of the RHB one that will
be in-scope.
> Restrict logger visibility throughout the codebase to private so that only
> the file that declares it can use it
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-8330
> URL: https://issues.apache.org/jira/browse/SOLR-8330
> Project: Solr
> Issue Type: Sub-task
> Affects Versions: 6.0
> Reporter: Jason Gerlowski
> Assignee: Anshum Gupta
> Priority: Major
> Labels: logging
> Fix For: 5.4, 6.0
>
> Attachments: SOLR-8330-combined.patch, SOLR-8330-detector.patch,
> SOLR-8330-detector.patch, SOLR-8330.patch, SOLR-8330.patch, SOLR-8330.patch,
> SOLR-8330.patch, SOLR-8330.patch, SOLR-8330.patch, SOLR-8330.patch
>
>
> As Mike Drob pointed out in Solr-8324, many loggers in Solr are
> unintentionally shared between classes. Many instances of this are caused by
> overzealous copy-paste. This can make debugging tougher, as messages appear
> to come from an incorrect location.
> As discussed in the comments on SOLR-8324, there also might be legitimate
> reasons for sharing loggers between classes. Where any ambiguity exists,
> these instances shouldn't be touched.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
