[
https://issues.apache.org/jira/browse/SOLR-14408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209470#comment-17209470
]
Alessandro Benedetti commented on SOLR-14408:
---------------------------------------------
I agree with [~dsmiley], [~nazerke] can you update the pull request to revert
the class externalisation?
I believe an inner class would suffice in this case.
> Refactor MoreLikeThisHandler Implementation
> -------------------------------------------
>
> Key: SOLR-14408
> URL: https://issues.apache.org/jira/browse/SOLR-14408
> Project: Solr
> Issue Type: Improvement
> Components: MoreLikeThis
> Reporter: Nazerke Seidan
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The main goal of this refactoring is for readability and accessibility of
> MoreLikeThisHandler class. Current MoreLikeThisHandler class consists of two
> static subclasses and accessing them later in MoreLikeThisComponent. I
> propose to have them as separate public classes.
> cc: [~abenedetti], as you have had the recent commit for MLT, what do you
> think about this? Anyway, the code is ready for review.
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
