[ 
https://issues.apache.org/jira/browse/SOLR-14408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205234#comment-17205234
 ] 

David Smiley commented on SOLR-14408:
-------------------------------------

I found {{org.apache.lucene.util.QueryBuilder.TermAndBoost}}  :-)    I just 
guessed what I would name this thing, and I guessed right.  There's a similar 
one inside SynonymQuery.  Perhaps Lucene ought to have a utility class for 
it... or not because it's so simple so just have it be an inner class to the 
functionality it's related to.  I think I would prefer that instead of a 
generic one -- thus put as an inner class of MoreLikeThisHelper.  That's my 
opinion, any way.

> Refactor MoreLikeThisHandler Implementation
> -------------------------------------------
>
>                 Key: SOLR-14408
>                 URL: https://issues.apache.org/jira/browse/SOLR-14408
>             Project: Solr
>          Issue Type: Improvement
>          Components: MoreLikeThis
>            Reporter: Nazerke Seidan
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The main goal of this refactoring is for readability and accessibility of 
> MoreLikeThisHandler class. Current MoreLikeThisHandler class consists of two 
> static subclasses and accessing them later in MoreLikeThisComponent.  I 
> propose to have them as separate public classes. 
> cc: [~abenedetti], as you have had the recent commit for MLT, what do you 
> think about this?  Anyway, the code is ready for review. 
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to