gerlowskija commented on a change in pull request #1921:
URL: https://github.com/apache/lucene-solr/pull/1921#discussion_r498307070



##########
File path: solr/solr-ref-guide/src/common-query-parameters.adoc
##########
@@ -307,11 +307,13 @@ The `echoParams` parameter controls what information 
about request parameters is
 
 The `echoParams` parameter accepts the following values:
 
-* `explicit`: This is the default value. Only parameters included in the 
actual request, plus the `_` parameter (which is a 64-bit numeric timestamp) 
will be added to the `params` section of the response header.
+* `explicit`: Only parameters included in the actual request, plus the `_` 
parameter (which is a 64-bit numeric timestamp) will be added to the `params` 
section of the response header.

Review comment:
       No, I don't know anything about it.  This is the first I've heard of an 
underscore param.
   
   It may be duplicitous with the 'rid' stuff I added recently, but that's not 
necessarily the case.  e.g. There's nothing here that suggests that a '_' value 
gets passed without change to shard-requests, afaict.  But it's worth following 
up on for sure, thanks for pointing it out @dsmiley 
   
   > I'm having trouble searching for it.
   No kidding!  Whoever put this in didn't have searchability in mind, that's 
for sure haha.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to