[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17195751#comment-17195751
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-14723:
------------------------------------------------------
Thanks for taking this [~shshnk28]. Your changes look good, but you should
remove the "class" attribute from other caches, not only filterCache (look at
{{queryResultCache}}, {{documentCache}} and {{fieldValueCache}})
bq. But I ran ant clean test twice and one test is failing in the modified
branch. The same does not fail in base branch which is without these commits.
Some tests are flaky, so they may be related for reasons unrelated to your
change unfortunately. That said, I haven't seen this test be very flaky, could
you paste the failure log here?
bq. The suggestion was to change it in default and example configsets but I
have also changed those which are under test-files.
Thanks, I think that's a good idea
bq. PS: ant clean test takes about an hr to run which does not help with rapid
testing
Yes, our tests take a long time (there are some efforts to speed them up). Some
things you can do to speedup is to run tests only in the components you want to
test (i.e. inside {{solr/core}} or {{solr/contrib/dataimporthandler}}, etc).
Also, when a test fails it'll print the exact command with which you can re-run
the same test. It'll look something like:
{noformat}
NOTE: reproduce with: ant test -Dtestcase=IndexSizeTriggerMixedBoundsTest
-Dtests.seed=CC3BE9E659E38BB -Dtests.slow=true -Dtests.locale=ar-IQ
-Dtests.timezone=America/St_Lucia -Dtests.asserts=true
-Dtests.file.encoding=UTF-8
{noformat}
A good start after seeing a failure is to run that line again.
> Rremove the class atribute for the caches in the _default/example configsets
> ----------------------------------------------------------------------------
>
> Key: SOLR-14723
> URL: https://issues.apache.org/jira/browse/SOLR-14723
> Project: Solr
> Issue Type: Improvement
> Reporter: Tomas Eduardo Fernandez Lobbe
> Priority: Trivial
> Labels: newdev
>
> In 8.x branch, the default and example configsets include LRUCache and
> FastLRUCache as the implementation for the various caches.
> {code:xml}
> <filterCache class="solr.FastLRUCache"
> size="512"
> initialSize="512"
> autowarmCount="0"/>
> {code}
> Those implementations are deprecated. We should remove the attribute
> completely and let the default take over (as it's in master), this should
> make upgrading configsets easier:
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
