[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17195599#comment-17195599
]
Shashank Shekhar commented on SOLR-14723:
-----------------------------------------
So I do have the changes in my forked branch. I have removed _class_ attribute
from 19 solrconfig.xml files. The commits in my forked repo can be viewed
[here|[https://github.com/shshnk28/lucene-solr/commit/bc7b5d30f29f2ca9e6737d2e169bfca61740f383]]
and
[here|[https://github.com/shshnk28/lucene-solr/commit/bf8668c358340fe3c3ae49ca8b6b3b6cc18051c6]].
But I ran _ant clean test_ twice and one test is failing in the modified
branch. The same does not fail in base branch which is without these commits.
{code:java}
// org.apache.solr.search.json.TestJsonRequest.testLocalJsonRequest
{code}
I ran _ant clean test_ in base branch once and it did not fail there.
Could it be because I have changed more _solrconfig.xmls_ than I was required
to?
The suggestion was to change it in _default_ and _example_ configsets but I
have also changed those which are under _test-files._
PS: _ant clean test_ takes about an hr to run which does not help with rapid
testing :)
> Rremove the class atribute for the caches in the _default/example configsets
> ----------------------------------------------------------------------------
>
> Key: SOLR-14723
> URL: https://issues.apache.org/jira/browse/SOLR-14723
> Project: Solr
> Issue Type: Improvement
> Reporter: Tomas Eduardo Fernandez Lobbe
> Priority: Trivial
> Labels: newdev
>
> In 8.x branch, the default and example configsets include LRUCache and
> FastLRUCache as the implementation for the various caches.
> {code:xml}
> <filterCache class="solr.FastLRUCache"
> size="512"
> initialSize="512"
> autowarmCount="0"/>
> {code}
> Those implementations are deprecated. We should remove the attribute
> completely and let the default take over (as it's in master), this should
> make upgrading configsets easier:
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
